[BridgeCard] Make HTML default, remove other buttons #2101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice idea, @Bockiii! We need to change button's label or change labels for "Show more/Show less". 2 buttons with "Show" at start a little bit confusing. I suggest rename "Show Feed" to "Generate feed'.
|
|
Done. 2 tries for 2 words, checks out. |
em92
changed the title
|
gj @Bockiii |
|
Users still need to be able to get the URL to atom for their feed readers, don't they? After this change I don't see that option anymore. On the Never mind. The vanishing is an issue with Brave's "shields." |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution to #2099
This will get rid of the list of buttons on the bridge overview and replace it with a single "show feed" button that goes to the html feed.
Unclutters the front, removes UX issues with the atom/mrss feed urls (you cannot use right-click-copy-link on the bridge overview but you can do it in the html view), adds the "hit enter and go to html feed" behavior.